Yoast SEO Premium usage tracking enables automatically every time after activating plugin

[worldsdream]

Yoast SEO Premium does not respect the "Usage tracking" setting. Yoast SEO does respect the usage tracking setting.

This is how to reproduce for Yoast SEO:

1. Install Yoast SEO
2. Enable Yoast SEO
3. Disable Usage tracking in the settings (General>Features>Usage tracking)
4. Disable Yoast SEO plugin
5. Enable Yoast SEO plugin
6. Go and check the usage tracking setting (General>Features>Usage tracking)
7. The Usage tracking setting is DISABLED

As you can see, the above is good and that's how it should be. It needs to respect the user settings when deactivating and activating the plugin.

Let's do the same steps, but this time for Yoast SEO Premium:

1. Install Yoast SEO
2. Install Yoast SEO Premium
3. Enable both Yoast SEO and Yoast SEO Premium
4. Disable Usage tracking in the settings (General>Features>Usage tracking)
5. Disable Yoast SEO Premium plugin
6. Enable Yoast SEO Premium plugin
7. Go and check the usage tracking setting (General>Features>Usage tracking)
8. The Usage tracking setting is ENABLED

As you can see, the above steps will retrigger and enable the "Usage tracking". This is not correct.

[mmikhan]

Thanks for bringing this to our attention. I was able to reproduce the issue on our end. Since it's an issue specific to premium, I opened an issue internally (IM-1901) and prioritized it to ensure a fix soon. Relevant initial PR: https://github.com/Yoast/wordpress-seo-premium/pull/2890

[worldsdream]

Glad that you are able to reproduce this @iamazik.