YoastSEO.js icon indicating copy to clipboard operation
YoastSEO.js copied to clipboard

Eye marker broken when sentence/paragraph contains a link

Open monbauza opened this issue 7 years ago • 3 comments

Please give us a description of what happened.

When the sentence or paragraph that is supposed to be highlighted contains a link, the eye marker does nothing.

Please describe what you expected to happen and why.

The relevant text to be highlighted no matter whether there's a link or not in the text.

How can we reproduce this behavior?

  1. Create a post
  2. Add some text (sample text below)
  3. Check that the eye marker for the multiple readability and keyword checks works as expected (image one below for the keyphrase distibution check)
  4. Add a link to one of the paragraphs and note that the eye marker doesn't highlight anything in the paragraph anymore

NOTE: This affects multiple readability and keyword checks: keyword distribution, keyword density, transition words, link keyphrase, etc.

Image One

image

Image Two

image

Technical info

  • WordPress version: 4.9.8
  • Yoast SEO version: 9.0

Related: https://github.com/Yoast/YoastSEO.js/issues/1155

Sample text

Lorem ipsum dolor sit amet, consectetur adipiscing elit. Maecenas a eros nec lectus accumsan pharetra vitae a erat. Duis egestas tellus eget massa imperdiet malesuada. Donec in lacinia magna. Etiam pulvinar, eros sed pulvinar cursus, odio dolor egestas risus, eu imperdiet mauris nibh rutrum justo. Maecenas id fermentum tellus. 

Lorem ipsum duis id interdum felis, vitae porttitor ex. Nulla in fringilla leo. Morbi in convallis justo, sit amet viverra nisl. Pellentesque eu velit eleifend, pellentesque tellus vulputate, dignissim mauris. Aenean mattis finibus neque a mattis. Phasellus lobortis libero vel ipsum consequat tempor. Maecenas quis massa vitae purus rutrum cursus.

Lorem ipsum maecenas pulvinar ultricies posuere. Maecenas tincidunt nisi leo, id pretium mi dignissim eget. Nulla a libero dictum, eleifend urna vitae, placerat justo. Sed ultricies lorem sit amet tortor iaculis, a tristique nisl consectetur. Quisque commodo orci porttitor orci dignissim, at fringilla tortor aliquet. Morbi congue mi ac erat posuere, a blandit nisl accumsan. Nulla ornare aliquam orci id cursus.

Lorem ipsum integer placerat eu quam vel porta. Ut tincidunt dolor nec accumsan consequat. Morbi dictum est in nibh molestie, sollicitudin cursus erat efficitur. Mauris ut nibh ultrices, sollicitudin sem eget, ultrices diam. Sed quis porta nisi. Donec consequat ante quis pulvinar tincidunt. Ut ante est, hendrerit vitae porta et, laoreet sit amet purus. Vivamus tristique elementum nulla, vestibulum tempus lectus fringilla suscipit.

monbauza avatar Oct 23 '18 12:10 monbauza

Please inform the customer of conversation # 435905 when this conversation has been closed.

monbauza avatar Oct 23 '18 12:10 monbauza

The issue is not reproduced with WP 5.0.3 and Yoast SEO 9.6.

screenshot 2019-02-20 at 13 25 21 screenshot 2019-02-20 at 13 25 33

@monbauza can you please confirm it?

dariaknl avatar Feb 20 '19 12:02 dariaknl

It doesn't occur in Gutenberg (I confirm it), but when the Classic Editor v1.4 plugin is activated, it still occurs.

monbauza avatar Feb 20 '19 13:02 monbauza