MeshCentral icon indicating copy to clipboard operation
MeshCentral copied to clipboard

Clipboard (get) not working in RDP connections when copying +54 characters

Open sammyke007 opened this issue 1 year ago • 1 comments

Describe the bug RDP clipboard (get) is not working if the clipboard on the remote PC contains more than 54 characters. This happens both in RDP Connect (via Desktop) and in Web RDP. Auto Clipboard or not doesn't make a difference. This is not a browser issue. Tested on multiple computers, multiple instances.

To Reproduce Connect with RDP to a remote computer. HOST -> REMOTE (Clipboard SET) always works. REMOTE -> HOST (Clipboard GET) only works for =< 54 characters.

Expected behavior Clipboard GET should copy > 55 characters too.

Screenshots

Server Software (please complete the following information):

  • OS: Debian
  • Virtualization: Docker
  • Network: Reverse proxy
  • Version: 1.1.19
  • Node: 20.11.0

Client Device (please complete the following information):

  • Device: multiple devices
  • OS: Windows
  • Network: ---
  • Browser: Google Chrome
  • MeshCentralRouter Version: ---

Remote Device (please complete the following information):

  • Device: multiple devices
  • OS: Windows
  • Network: ---

sammyke007 avatar Jan 23 '24 10:01 sammyke007

Notes: I've narrowed down the issue to here https://github.com/Ylianst/MeshCentral/blob/master/rdp/protocol/pdu/cliprdr.js#L73-L104 It seems when it does the clipPDU, the offset is 11 instead of 10? And it seems like the data that get received has an extra byte? I just can't work out why or where?

si458 avatar Feb 13 '24 19:02 si458