Zmanim icon indicating copy to clipboard operation
Zmanim copied to clipboard

Published 20 hours ago • verified publisher icon Yitzchok

Added FormatParsha function - fix Lag Be'omer formatting

Open shmulyeng opened this issue 2 years ago • 4 comments

Hebrew version of Lag Be'omer uses the Beis prefix regardless of what's used for other days.

shmulyeng avatar May 13 '22 01:05 shmulyeng

Any chance of getting this merged?

shmulyeng avatar Apr 18 '23 20:04 shmulyeng

It looks like you also have a parsha change can you explain what the change does?

Yitzchok avatar Apr 19 '23 17:04 Yitzchok

It looks like you also have a parsha change can you explain what the change does?

I added a blank string to the beginning of the array to align the parsha enum with the Hebrew Parsha array. The enum has a "None" value as the first value.

I also added a method to format the Parsha in Hebrew based on date or Parsha.

shmulyeng avatar Apr 19 '23 17:04 shmulyeng

Can this get merged?

shmulyeng avatar Jan 10 '24 00:01 shmulyeng