KAML icon indicating copy to clipboard operation
KAML copied to clipboard

Cross-validation Finished_2.00%Error in mult.store[, 2] : subscript out of bounds

Open Markjiancheng opened this issue 4 years ago • 11 comments

Hi, hope you are doing well. I am trying KAML for some data but I always get this error: Cross-validation Finished_2.00%Error in mult.store[, 2] : subscript out of bounds

And this for a different data: Pick up pseudo QTNs at LD threshold(0.3) as following: Error in if (sum(p_cor > cor.threshold) == 0) bin.qtn[[g]] <- c(bin.qtn[[g]], : missing value where TRUE/FALSE needed

Would you please help with these issues? Thanks!

Markjiancheng avatar Oct 28 '21 13:10 Markjiancheng

Hi Mark,

Thanks for trying KAML, we haven't caught this error by now using the data in hand, may i please ask for a small dataset which can repeat the error as you proposed? i am pleased to debug the script of KAML for this issue, and feed back to you as soon as possible.

Best, Lilin

YinLiLin avatar Oct 30 '21 00:10 YinLiLin

Hi YinLiLin,

Thanks for your prompt reply, I actually tried the horse and maize data that you used in your paper, but I am not sure why both of them did not work. Attached is the exact code and data I used, please see attached GDD.zip Horse.zip !

Markjiancheng avatar Oct 30 '21 01:10 Markjiancheng

Hi, I just tried both of the data attached, it works fine on my computer, the LOG information can be found below: horse.log GDD.log Did you use the latest version of KAML that was installed from Github?

YinLiLin avatar Nov 01 '21 00:11 YinLiLin

I think so. I just installed according to the instruction recently.

Markjiancheng avatar Nov 01 '21 16:11 Markjiancheng

Thank you for pointing out this issue, we have located the problem, and the latest script on GitHub can be run successfully on different version of R, please try again.

YinLiLin avatar Nov 05 '21 00:11 YinLiLin

Thanks for checking it out, however, the problem still exist: Error in if (sum(p_cor > cor.threshold) == 0) bin.qtn[[g]] <- c(bin.qtn[[g]], : missing value where TRUE/FALSE needed

Moreover, it looks like computing grm took me longer than before, is it because that you updated the package?

Markjiancheng avatar Nov 05 '21 02:11 Markjiancheng

Yes, we have changed the computing strategy for GRM construction, it take less memory than previous version. Can the updated version run "horse" and "GDD" data successfully on your computer? Or it just failed for your own data? if in this case, could you mind sending me a small data? i need to repeat this issue to get it fixed.

YinLiLin avatar Nov 05 '21 03:11 YinLiLin

No, it failed on the GDD data.

Markjiancheng avatar Nov 05 '21 13:11 Markjiancheng

May i know the version of R you used and the operating system (linux, windows, mac) of your computer?

YinLiLin avatar Nov 08 '21 00:11 YinLiLin

It is R 4.1.1 in Linux.

Markjiancheng avatar Nov 08 '21 14:11 Markjiancheng

I just ran KAML at the same environment as yours (R 4.1.1, Linux), it can still work without problem, please see the log file below: KAML_R-4.1.1_run.log Sorry that it seems there may be potential problem which would be encountered at specify systematical environment, so I recommend to have a try at another computer.

YinLiLin avatar Nov 10 '21 08:11 YinLiLin