dongfang

Results 23 comments of dongfang

可以扩展一下deps参数的数据类型?比如支持 `{ deep: true, deps: [dep1, dep2] }` 这种结构,这样全部的 useXxxxxEffect 都不用额外封装就可以支持deepCompare 甚至可以额外支持`strictNull`:是否严格区分`null`,`undefined`, `compare`:自定义比较函数等

Looks like because of this ![image](https://user-images.githubusercontent.com/16241981/227478733-6d8c16a5-3e29-4429-b51e-743d0088d5fd.png) Why use `Math.min`? When `textElementHeight` is much bigger than `maxHeight`, container's height grow only `element.lineHeight`(1.2) every call. Because of this, multi-line text pastes always...

看起来是`Slider`组件中使用`Tooltip`时设置了自定义的`transitionName`为`zoom-down`,但是在`Tooltip`组件中只注册了`zoom-big-fast`动画,缺少`zoom-down`

PR内容已更新 这个问题:修复中文页面文档跳转到英文页面问题(当打开中文页面时,为页面的Link组件中的url地址自动添加-cn后缀) 我看有PR手动更新了全部的中文文档地址,这个commit还是否需要?

You defined `LocationForm` as a function component in render phase of `App` component. So it will render a new `LocationForm` component (without any internal state) every time of render phase....

> @YinDongFang You are right, it is not a bug, but my fault. Thanks for explaining. I would still be interested why you recommended step 2? It seems to work...

> * [feat: ConfigProvider support select.showSearch #38242](https://github.com/ant-design/ant-design/pull/38242) 和这个MR内容一样,只是处理了冲突。上个MR操作错误关闭了

目前`rc-field-form`中已经通过`FieldContext`实现。可以单独实现一个`PrefixContext`并且暴露出来 PR:https://github.com/react-component/field-form/pull/541

业务自行实现的问题在于`List`组件已经添加了`prefixName`,在`List`中的`Item`会出现问题 比如:https://codesandbox.io/s/prefixnamecontext-demo-m7l7pz