YimMenu icon indicating copy to clipboard operation
YimMenu copied to clipboard

[Request]: Enforce spaces / line ending in a commit checker

Open xiaoxiao921 opened this issue 2 years ago • 2 comments

Problem

the clang format use tabs, not sure why? I propose https://github.com/YimMenu/YimMenu/blob/master/.clang-format#L67

UseTab: Never

Solution

A simple github action that check for any \t and make the pr not mergeable would be a great thing imo

Reason

incoming pr / whats on the repo always differ, which break git diffs / make them much more annoying to read

Additional context

No response

xiaoxiao921 avatar Jun 13 '23 14:06 xiaoxiao921

I thought YimMenu prefers tabs over spaces. https://github.com/YimMenu/YimMenu/blob/master/CONTRIBUTING.md#indents

Why even not allow tabs besides breaking git diffs which should be fixed in the opposite way?

tupoy-ya avatar Jun 13 '23 14:06 tupoy-ya

the pr is more about an unified way of doing it

xiaoxiao921 avatar Jun 13 '23 14:06 xiaoxiao921