laravel-commerce icon indicating copy to clipboard operation
laravel-commerce copied to clipboard

Published 20 hours ago • verified publisher icon Yiddishe-Kop

Duplicate offer validity check

Open shayaulman opened this issue 1 year ago • 0 comments

Any reason why you have to check here again if an offer is valid:

https://github.com/Yiddishe-Kop/laravel-commerce/blob/b707c1927a26bb74ecc22190b51d826f78472673/src/Traits/HandlesCartItems.php#L214

After it already has been checked in getFor:

https://github.com/Yiddishe-Kop/laravel-commerce/blob/b707c1927a26bb74ecc22190b51d826f78472673/src/Models/Offer.php#L47-L68

shayaulman avatar Jun 29 '23 07:06 shayaulman