nativescript-mapbox
nativescript-mapbox copied to clipboard
Support for NS7
- had to bump typescript version
- dropped deprecated tns-core-modules and nativescript-angular deps
- updated Angular to 10 in demo-angular
- ran tslint in all projects: demo, demo-angular and mapbox itself
any update or schedule for this one? let me know if a helping hand is needed
@cvietor I'll close the task today, but otherwise this needs to be tested (CI isn't configured for PRs) and merged by someone.
@autaut03 Yea, I need to get back to working on the plugin and merge a number of PRs. I've been swamped for the last few months with a project that's taking 100%+ of my time but is finally nearing an end. Then I will spend a few weeks focused on the plugin. I apologize about the delay.
@autaut03 i tried to run your PR and it seems to be working (some styles in angular demo seem to be messed up, but that could be my machine). i noticed that the demo app (core, non-ng) is not yet migrated to ns7, which should run smoothly with ns migrate
@autaut03 seems you and me just tried android, your PR does not work on iOS. but there is not much to do to fix that:
- in
mapbox.ios.ts
add@NativeClass()
decorator to:- class MGLMapViewDelegateImpl
- class MapTapHandlerImpl
- class MapLongPressHandlerImpl
- class MapPanHandlerImpl
- class MapSwipeHandlerImpl
- add
ts-patch
tosrc/package.json
- modify npm build script:
"scripts": { "build": "npm i && ts-patch install && tsc --skipLibCheck", ...
- add "plugins" section to
src/tsconfig.json
:
"plugins": [{
"transform": "@nativescript/webpack/transformers/ns-transform-native-classes",
"type": "raw"
}]
the mapbox plugin is now an will remain maintained at @nativescript-community https://github.com/nativescript-community/ui-mapbox. We released the new plugin for N7 with a lot of fixes https://www.npmjs.com/package/@nativescript-community/ui-mapbox