nativescript-mapbox icon indicating copy to clipboard operation
nativescript-mapbox copied to clipboard

Support for NS7

Open autaut03 opened this issue 4 years ago • 6 comments

  • had to bump typescript version
  • dropped deprecated tns-core-modules and nativescript-angular deps
  • updated Angular to 10 in demo-angular
  • ran tslint in all projects: demo, demo-angular and mapbox itself

autaut03 avatar Sep 15 '20 19:09 autaut03

any update or schedule for this one? let me know if a helping hand is needed

cvietor avatar Oct 07 '20 06:10 cvietor

@cvietor I'll close the task today, but otherwise this needs to be tested (CI isn't configured for PRs) and merged by someone.

autaut03 avatar Oct 07 '20 11:10 autaut03

@autaut03 Yea, I need to get back to working on the plugin and merge a number of PRs. I've been swamped for the last few months with a project that's taking 100%+ of my time but is finally nearing an end. Then I will spend a few weeks focused on the plugin. I apologize about the delay.

Yermo avatar Oct 07 '20 18:10 Yermo

@autaut03 i tried to run your PR and it seems to be working (some styles in angular demo seem to be messed up, but that could be my machine). i noticed that the demo app (core, non-ng) is not yet migrated to ns7, which should run smoothly with ns migrate

cvietor avatar Oct 15 '20 05:10 cvietor

@autaut03 seems you and me just tried android, your PR does not work on iOS. but there is not much to do to fix that:

  • in mapbox.ios.ts add @NativeClass() decorator to:
    • class MGLMapViewDelegateImpl
    • class MapTapHandlerImpl
    • class MapLongPressHandlerImpl
    • class MapPanHandlerImpl
    • class MapSwipeHandlerImpl
  • add ts-patch to src/package.json
  • modify npm build script: "scripts": { "build": "npm i && ts-patch install && tsc --skipLibCheck", ...
  • add "plugins" section to src/tsconfig.json:
"plugins": [{
  "transform": "@nativescript/webpack/transformers/ns-transform-native-classes",
  "type": "raw"
}]

cvietor avatar Oct 31 '20 09:10 cvietor

the mapbox plugin is now an will remain maintained at @nativescript-community https://github.com/nativescript-community/ui-mapbox. We released the new plugin for N7 with a lot of fixes https://www.npmjs.com/package/@nativescript-community/ui-mapbox

farfromrefug avatar Nov 13 '20 13:11 farfromrefug