Added above/below options to addLayer/addPolygon/addPolyline

[lochstar]

I noticed that new layers were being added above the markers. This may not always be desirable. I've added optional params above and below.

I've also added above and below to addPolygon and addPolyline. This resolves #188 & #308.

I've also fixed addSource, removeSource, addLayer, deleteLayer when calling from an XML map (shoud have tested this initially).

I'm also working on location layer customisations. I'll submit a PR soon.

[Codex-]

Looks like a reasonably nice solution to the problems reported 👌 was looking at doing this too

[Codex-]

FYI I've been working on bringing this package up to date and resolving the build issues as well, if there were any concerns around merging this despite the build failing. Currently the lint fails due to existing code in the typings (A bunch of rogue readonlys with nothing after them).

[Codex-]

PR opened to resolve the build issues amongst other things. These changes don't break the build (tested locally): https://github.com/EddyVerbruggen/nativescript-mapbox/pull/311

[Codex-]

Tested these changes on my branch, all seems 👌

[Codex-]

@lochstar my PR was accepted, so you'll need to resolve / rebase probably.

[lochstar]

@Codex- Sorted!

[lochstar]

@EddyVerbruggen Can we get this merged? :)

[Codex-]

Probably won't until the failing build is resolved?

[lochstar]

Thanks @Codex-

[alexonozor]

How do I run the branch containing the addsource and addLayer?

[lochstar]

@alexonozor For some reason addSource and addLayer was broken/left out in the last batch of major updates to this branch.

I'm currently working on a fork that has NS7 updates and addSource/addLayer fixes here: https://github.com/codelabau/nativescript-mapbox

[alexonozor]

@alexonozor For some reason addSource and addLayer was broken/left out in the last batch of major updates to this branch.

I'm currently working on a fork that has NS7 updates and addSource/addLayer fixes here: https://github.com/codelabau/nativescript-mapbox

I referenced the packages like this in my package.json "nativescript-mapbox": "file:../publish/dist/package" after building the package:

cd src npm run build.debug but I get this error

Cannot read property 'addSource' of undefined or map not loaded

[lochstar]

@alexonozor iOS or Android? I've only updated Android so far.