Lower privilege for setup

[tresf]

• sudo isn't need for wget
• sh prevents needing chmod
• odoo_install.sh asks for credentials naturally

[Yenthe666]

@tresf,

Thanks for the PR / ideas. For the sudo: this is because some people try to do this in a folder where they have not enough rights, sudo will always 'win' in this case. For the second part, I never tried the differences so I'll try it as soon as possible to check. thanks!

[tresf]

For the sudo: this is because some people try to do this in a folder where they have not enough rights, sudo will always 'win' in this case.

No they don't. Please don't spread this stuff around, it's simply incorrect. A terminal defaults to ~, moving forward you should always write your scripts to honor that. Never run something as sudo that doesn't need root access to the system. All this does is create a file that can't be easily deleted in a user's home directory and that's wrong. 😃

For the second part, I never tried the differences so I'll try it as soon as possible to check. thanks!

For the record, the script fails on Ubuntu 14.04 and the others I've found on the internet seem to fail as well. It may be worth porting the repo to Circle-CI or Travis-CI or something to make sure it works. This process was quite involved so I ended up installing Odoo on Windows just to try it out (still struggling there as well, but that's another topic).

But please move away from sudo. It has no place in a wget call that places something in ~.