paasta icon indicating copy to clipboard operation
paasta copied to clipboard

fixes for vscode test parser

Open cuza opened this issue 2 years ago • 4 comments

Making VSCode test parser happy

image

cuza avatar Aug 21 '23 19:08 cuza

@cuza what is the current code doing to make VSCode unhappy? is it crashing or something on creating the spark config?

(i've also CC'd @CaptainSame since they recently touched this code)

nemacysts avatar Aug 21 '23 19:08 nemacysts

@nemacysts

==================================== ERRORS ====================================
______________ ERROR collecting tests/cli/test_cmds_spark_run.py _______________
tests/cli/test_cmds_spark_run.py:513: in <module>
    @mock.patch.object(spark_config.SparkConfBuilder(), "get_history_url", autospec=True)
E   AttributeError: module 'service_configuration_lib.spark_config' has no attribute 'SparkConfBuilder'
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
=========================== 1 error in 2.02 seconds ============================

cuza avatar Aug 21 '23 19:08 cuza

Looks minor so I'll merge if the tests pass in a mo rather than closing

mattmb avatar Feb 21 '24 15:02 mattmb

@cuza do we still need/want this?

nemacysts avatar Apr 02 '24 14:04 nemacysts