paasta icon indicating copy to clipboard operation
paasta copied to clipboard

Extend Kubernetes Custom Resources with general yelpsoa-configs

Open flavray opened this issue 5 years ago • 4 comments

This commit extends the configuration/custom resources submitted to Kubernetes for services deployed there (this is targetting resources managed by operators).

Re-using the logic used in marathon_tools.py, reading the "general" service configuration (monitoring.yaml, smartstack.yaml, etc...) and merging it with every instance configuration found in kubernetes-{cluster} files.

Shipping this change will cause the paasta.yelp.com/config_sha label to be updated even if the CRs themselves will not change. Not sure whether that is an issue for existing operators?


  • make test passes
  • Tested on a local run of the kafka-operator (setup_kubernetes_cr)
    • New CR spec here
    • The CR specs do not change after applying with the "extended" resource (extra fields are ignored by the operator as they are not in the CRD). (BeforeAfter)

flavray avatar May 05 '20 08:05 flavray

Updating paasta.yelp.com/config_sha means that operators will restart pods and other resources they manage, which probably isn't good for some of them.

vkhromov avatar May 05 '20 10:05 vkhromov

flink-operator should ignore paasta.yelp.com/config_sha by now, so this should not lead to any service restart afaik. Given that without a change in the CRD the spec won't even be updated, this should not be a problem either. (cc @Bronek in case I am grossly mistaken)

Out of curiosity, what is this change for? Are we preparing to add any of the other configurations into paasta-tools-go?

poros avatar May 05 '20 12:05 poros

@Rob-Johnson I did not mean to re-request your review, I misclicked and I can't undo, sorry :/

poros avatar May 05 '20 12:05 poros

@flavray , do you mind rebasing from master?

Bronek avatar May 06 '20 13:05 Bronek

Cleaning up and closing some very old PRs. Please re-open or nudge me if you’re still planning to work on this.

mattmb avatar Feb 21 '24 11:02 mattmb