nrtsearch icon indicating copy to clipboard operation
nrtsearch copied to clipboard

Published 20 hours ago • verified publisher icon Yelp

Consider removing synchronization on indices

Open sarthakn7 opened this issue 4 years ago • 0 comments

indices in GlobalState is synchronized in the getIndex method: https://github.com/Yelp/nrtsearch/blob/6b2166948728e0a2c87b3c227b401781e0be38b6/src/main/java/com/yelp/nrtsearch/server/luceneserver/GlobalState.java#L234

This method is called in a lot of places (via another getIndex method) and we should consider removing the synchronization. The indices variable is already a concurrent hashmap.

sarthakn7 avatar Oct 21 '20 20:10 sarthakn7