dumb-init icon indicating copy to clipboard operation
dumb-init copied to clipboard

Add riscv64 support

Open luhenry opened this issue 2 months ago • 7 comments

This PR adds support for RISC-V following the recent release of Debian Trixie on riscv64 as a stable target [1]. This also unblocks packaging and distributing Gitlab Runners on riscv64.

[1] https://www.debian.org/releases/trixie/

luhenry avatar Oct 31 '25 15:10 luhenry

@chriskuehl given some of the commits are not entirely related to riscv64 support (bump to bullseye and bump autopep8 pre-commit), I'm happy to break these two into seperate PRs if you prefer, just let me know. Thanks again for all your hard work on that! :)

luhenry avatar Oct 31 '25 15:10 luhenry

Full successful run on CI at https://github.com/luhenry/dumb-init/actions/runs/19029374564

luhenry avatar Nov 03 '25 09:11 luhenry

Hi @chriskuehl :wave: I'm on the GitLab Runner team. Merging this ~MR~PR would unblock a couple of MRs that round out riscv64 support for gitlab-runner. It'd be excellent get this PR merged ASAP :pray:. Cheers.

bertoldia avatar Nov 04 '25 17:11 bertoldia

unfortunately neither Chris nor I work at yelp any more so it might be unmaintained

asottile avatar Nov 04 '25 19:11 asottile

@kentwills You appear to still be at Yelp. Are you able to give this MR some love?

bertoldia avatar Nov 04 '25 20:11 bertoldia

tbf I don't think you actually need this merged here to use dumb-init on trixie: https://packages.debian.org/trixie/dumb-init

and I don't think this PR should be merged as is -- it should be split into the separate individual patches such that it can be properly reviewed

asottile avatar Nov 04 '25 20:11 asottile

tbf I don't think you actually need this merged here to use dumb-init on trixie: https://packages.debian.org/trixie/dumb-init

That's a good point. I'll take that back to the Gitlab Runner team and see what they want to do. It's also available in the Ubuntu and Alpine package managers.

and I don't think this PR should be merged as is -- it should be split into the separate individual patches such that it can be properly reviewed

Happy to do so regardless of what Gitlab wants to do (distro package manager or download releases), just to leave it better than how I found it :)

luhenry avatar Nov 04 '25 21:11 luhenry