detect-secrets icon indicating copy to clipboard operation
detect-secrets copied to clipboard

Published 20 hours ago • verified publisher icon Yelp

Extend keywords

Open nimrodkor opened this issue 1 year ago • 2 comments

  • Please check if the PR fulfills these requirements
  • [x] Tests for the changes have been added
  • [ ] Docs have been added / updated
  • [x] All CI checks are green
  • What kind of change does this PR introduce? Added 2 new keywords to the keyword detector that we found to be rampant:
  1. stuff that ends with _pass
  2. token

  • What is the current behavior? secrets are not being flagged

  • What is the new behavior (if this is a feature change)? these secrets are being flagged

  • Does this PR introduce a breaking change? No

  • Other information:

nimrodkor avatar Jan 16 '23 12:01 nimrodkor

Had to remove python 3.6 as it isn't supported any longer by GHA. Now I see it is failing on finding secrets in my changes :( Help would be appreciated, I'm sure I didn't add any secret...

nimrodkor avatar Jan 16 '23 13:01 nimrodkor

Hi. Please merge master to your branch to re-run CI.

jpdakran avatar Mar 28 '23 17:03 jpdakran