bravado icon indicating copy to clipboard operation
bravado copied to clipboard

Published 20 hours ago • verified publisher icon Yelp

SwaggerClient.from_url should have timeout

Open guerda opened this issue 5 years ago • 2 comments

The requests in bravado can be configured to have a timeout. Unfortunately, this does not affect the from_url() method. Would it be possible to add a time out feature in that method, too?

Best, Philip

guerda avatar May 15 '20 11:05 guerda

Maybe it's possible to insert the timeout into the request headers here: https://github.com/Yelp/bravado/blob/f8f98c00c3422f977ae44b4ef7e37350b05f6ea5/bravado/client.py#L95

guerda avatar May 28 '20 06:05 guerda

We'll need to pass a timeout argument to the result call. The best option is probably to add a timeout argument to SwaggerClient.from_url and pass it down the call chain. @guerda, would you be interested in working on a PR?

sjaensch avatar May 28 '20 08:05 sjaensch