bravado-core icon indicating copy to clipboard operation
bravado-core copied to clipboard

jsonschema processing doesn't support jsonschema>=4.0.0 causing bravado to break when working in offline environment

Open HubertJaworski opened this issue 2 years ago • 2 comments

When running an installation on clean python environment, Bravado gets installed with the newest jsonschema, currently >=4.0.0

jsonschema 4.0.0 introduced support for newer draft versions, which does not follow the previous pattern of http://json-schema.org/draft-\d+/schema and with values like http://json-schema.org/draft-2019-09/schema

In bravado_core/model.py:883 your regexp for excluding jsonschema's default schemas should be changed to 'http://json-schema.org/draft-\d+(-\d+)?/schema'

Currently, when using bravado in offline environments, attempting to make request fails and crashes the program

HubertJaworski avatar Feb 25 '22 08:02 HubertJaworski

I, too, encountered this problem

GuySuday avatar Apr 26 '22 16:04 GuySuday

I have the same problem. I opened a PR for it: https://github.com/Yelp/bravado-core/pull/389

joern-m-h avatar May 18 '22 13:05 joern-m-h