bravado-core icon indicating copy to clipboard operation
bravado-core copied to clipboard

Published 20 hours ago • verified publisher icon Yelp

Some changes which enabled me to use the PagerDuty swagger

Open jakedt opened this issue 8 years ago • 3 comments

jakedt avatar Dec 13 '16 20:12 jakedt

Coverage Status

Coverage decreased (-0.2%) to 97.295% when pulling 1700898f020369746e9884d9115c26474cfe6d25 on jakedt:allof_responses into 24461141a308eeca4f997b48b4c4deacaef8c12a on Yelp:master.

coveralls avatar Dec 13 '16 20:12 coveralls

This is a great contribution, but unfortunately the build fails and tests are missing, decreasing coverage.

@jakedt, would you mind adding proper tests so this can be merged in? It is highly useful.

This is referenced in issue #7.

advance512 avatar Jan 28 '17 15:01 advance512

@jakedt thanks for your contribution! Would you be able to add a few tests that verify the new behavior? Ignore the py26 test failure for now, I think we'll remove Python 2.6 support real soon now.

sjaensch avatar Feb 02 '17 16:02 sjaensch