Resonite-Issues icon indicating copy to clipboard operation
Resonite-Issues copied to clipboard

Log file sometimes gets spammed with message `Error running discord callbacks: NotRunning`

Open Nytra opened this issue 1 year ago • 7 comments

Describe the bug?

Sometimes when launching Resonite the log file will be full of a message about an error running discord callbacks.

The exact message: Error running discord callbacks: NotRunning

I definitely did have Discord running on my computer when this error happened.

To Reproduce

~I don't know of any exact steps to reproduce this, but it has happened to me several times over the past months. It seems to be rare.~

  1. Make sure Discord is running on your computer
  2. Start Resonite normally
  3. Kill the Discord process on your computer (You can right click Discord in taskbar and click "Quit Discord")
  4. Note that the log file is now spammed with the message

Expected behavior

This message is not spammed in the log file.

Screenshots

No response

Resonite Version Number

Beta 2024.3.12.1169

What Platforms does this occur on?

Windows

What headset if any do you use?

Quest 3

Log Files

DESKTOP-H976HO2 - 2024.3.12.1169 - 2024-03-21 05_13_03.log

Edit with new log file after following above replication steps:

DESKTOP-H976HO2 - 2024.3.12.1169 - 2024-03-22 08_45_02.log

Additional Context

N/a

Reporters

Nytra (discord: nytra)

Nytra avatar Mar 21 '24 05:03 Nytra

Having replication steps would help immensely here. Can this issue be replicated if Discord isn't running at all/is launched or relaunched after Resonite is open, or any other similar combination of things? Can you correlate it to any other conditions, e.g. Discord updating itself?

LexiBasilisk avatar Mar 21 '24 20:03 LexiBasilisk

@shiftyscales Having tested it now, it does seem this can be replicated by simply killing the Discord process after Resonite has started running.

New replication steps:

  1. Make sure Discord is running on your computer
  2. Start Resonite normally
  3. Kill the Discord process on your computer (You can right click Discord in taskbar and click "Quit Discord")
  4. Note that the log file is now spammed with the message

New log file following the above steps:

DESKTOP-H976HO2 - 2024.3.12.1169 - 2024-03-22 08_45_02.log

Nytra avatar Mar 22 '24 08:03 Nytra

Yeah i know what this is.

ProbablePrime avatar Mar 22 '24 08:03 ProbablePrime

@Nytra Did Discord restart, update or lose internet connection during this period?

ProbablePrime avatar May 01 '24 07:05 ProbablePrime

@ProbablePrime I don't recall, sorry.

Nytra avatar May 01 '24 08:05 Nytra

Ok, It seems like if Discord restarts or "blips" we need to re-instantiate the link to it. The docs aren't great in this area.

ProbablePrime avatar May 01 '24 08:05 ProbablePrime

I've been taking a look at this one and updated things. In a branch, I've swapped the logging to only log, status codes that are not "Not Running", "Not Installed"

We have no way, to detect or receive an event from Discord for when it turns from NotRunning -> Running. So we basically have to "keep" guessing.

With Not Installed, we also disable the Discord functionality, when we detect, that. This might help/resolve #2022 too but I want to double check how the Headless responds after this change.

ProbablePrime avatar Oct 04 '24 01:10 ProbablePrime

Was about to get this rolling before I went on vacation, it's close.

ProbablePrime avatar Oct 21 '24 02:10 ProbablePrime

Merged the fix in 2024.10.29.1229, thanks for report!

Frooxius avatar Oct 29 '24 20:10 Frooxius