Locale icon indicating copy to clipboard operation
Locale copied to clipboard

scope of automated Github CI checks for pull requests

Open Muppeq opened this issue 1 year ago • 2 comments

If there was a json key change in the en.json file all translations are failing their checks as they have (now) unknown keys. I avoid messing around in other language json files that I can't understand, but that would now be needed to get new translations past the automated Github checks.

I suggest changing the check after PR creation to only include the json files changed in this PR, so that there is no need to delete lines in or edit other languages files just to get your own changes passing.

Of course this leaves language files with now unknown keys in the repository, but that is the same situation as after the key change and before merging in a PR. As I understand it resonite just ignores these lines.

Muppeq avatar May 07 '24 10:05 Muppeq

I agree, ill work on this as soon as I can.

ProbablePrime avatar May 07 '24 11:05 ProbablePrime

@jae1911 Do you have any interest in taking this one too?

You can find my existing action here: https://github.com/Yellow-Dog-Man/locale-checker-action/blob/main/index.js

The crux of the issue is, "only include the json files changed in this PR". But please ask questions if you have them.

ProbablePrime avatar Jul 28 '25 23:07 ProbablePrime