kissnet icon indicating copy to clipboard operation
kissnet copied to clipboard

Published 20 hours ago • verified publisher icon Ybalrid

Rationalize testing

Open Ybalrid opened this issue 5 years ago • 2 comments

Currently the CI is only there to check the syntax of the header code.

There are a few odd test programs in /tests/, but nothing really useful.

New test should be written using Catch2

Ybalrid avatar Sep 29 '19 11:09 Ybalrid

This is a good idea. I would propose having CMake FetchContent Catch2 rather than vendoring or Git Submodule, to avoid cluttering kissnet Git history. Specifically, if the user has set kissnet_BUILD_TESTING=true, then Catch2 will be downloaded, built and run the unit tests. Meson can effectively do the same thing, downloading and building Catch2 when tests are requested.

scivision avatar Dec 04 '20 00:12 scivision

Another thought is Catch2 is preparing a v3 release. The API has some changes, so maybe it's worth waiting for Catch2 v3?

scivision avatar Dec 06 '20 01:12 scivision