logo-ls icon indicating copy to clipboard operation
logo-ls copied to clipboard

UID lookup is bad

Open james-antill opened this issue 4 years ago • 1 comments

If you can't find a user you should use the UID not the empty string. Here:

https://github.com/Yash-Handa/logo-ls/blob/f6f6bee4156bf08340cce5246963e6eb26d1ce3d/formatterStuff.go#L88

...then two lines later you should print u.Username not u.Name:

https://github.com/Yash-Handa/logo-ls/blob/f6f6bee4156bf08340cce5246963e6eb26d1ce3d/formatterStuff.go#L90

...the first problem is repeated for group lookup error path.

james-antill avatar Sep 22 '20 22:09 james-antill

You could also save a bit of space/time by creating the map as map[uint64]string and then testing before you have to do strconv.Itoa().

james-antill avatar Sep 22 '20 22:09 james-antill