New-Star icon indicating copy to clipboard operation
New-Star copied to clipboard

Negative value verification

Open Ronneraz opened this issue 2 years ago • 2 comments

i find many num input limit is work in browser,so players can only use the F12 to del the “min” HTML tag。then they can make very much stardust or other resouses and ships in a few seconds like the pic p1。i try to find the php and fix one page successd but i have no time to test all page。now i only replace ALL

$amount = HTTP::_GP('amount', 0);

by

$amount = HTTP::_GP('amount', 0);
		if ($amount<=0){
			$amount=0;
		}

it works correctly in page (ShowIdeologiesPage.class.php) and (ShowArtifactPage.class.php),you can also change it to “return” easily or Reset it to zero,For your convenience。 in theory,this is all page with this code are also has this bug,you can also fix them

at last,i find many other bugs but i don‘t know how to fix they are suit,do you have the telegram or other im soft?i think it can raise working efficiency。

image

image

Ronneraz avatar Jun 26 '22 21:06 Ronneraz

sorry for my english is not very well,so i as far as possible to use the picture instead the text。the application of Alliance are can't del by players,it only can be pass or reject by the Alliance,i fix it to add a button in(WWW\styles\theme\nsc\templates\game\page.playerCard.default.tpl),then it is works correctly

{if $allyname}[<a href="#" onclick="parent.location = 'game.php?page=alliance&amp;mode=info&amp;id={$allyid}';return false;" class="playercrd17">{$allyname}]</a>{else}{/if}

Ronneraz avatar Jun 26 '22 21:06 Ronneraz

the file 【\includes\pages\game\ShowMarketPage.class.php】184lines if (empty($lot) || $price == 0){ should change to if (empty($lot) || $price < 1){ or the players can also use the f12 to enter the negative number for the price

Ronneraz avatar Jul 01 '22 01:07 Ronneraz