YarnSpinner-Unity icon indicating copy to clipboard operation
YarnSpinner-Unity copied to clipboard

DialogueRunner parameter added to DialoguePresenterBase / DialogueViewBase

Open nrvllrgrs opened this issue 8 months ago • 0 comments

  • Please check if the pull request fulfills these requirements
  • [x] Tests for the changes have been added (for bug fixes / features)
    • [x] Does it pass all existing unit tests without modification?
      • If not, what did you change?
      • If you altered it significantly, what coverage issue did you fix?
  • [ ] Docs have been added / updated (for bug fixes / features)
  • [x] CHANGELOG.md has been updated to describe this change
  • What kind of change does this pull request introduce?
  • [x] Bug Fix
  • [x] Feature
  • [ ] Something else
  • What is the current behavior?

Fixed compiler error in Localization if USE_ADDRESSABLES is included -- where multiple GetLocalizedObjectAsync methods are defined.

  • What is the new behavior (if this is a feature change)?

DialogueRunner has been added as a parameter to the DialoguePresenterBase and DialogueViewBase. This allows users to more easily share the presenters and views between DialogueRunners. For example, if multiple runners are running simultaneously, the line presenter can determine which subtitles should be displayed based on player distance to runner or other criteria.

  • Does this pull request introduce a breaking change?

This change adds a DialogueRunner parameter to the DialoguePresenterBase and DialogueViewBase -- requiring users to update any extended classes.

  • Other information:

YarnProjectImporter.GenerateStringsTable() is public to match 2.5 behavior.

nrvllrgrs avatar Feb 21 '25 13:02 nrvllrgrs