Yannik Sembritzki

Results 140 comments of Yannik Sembritzki

@tlimoncelli Regarding 2: this is surely due to `ListDomains()` not being implemented for these providers. However, it shouldn't crash but throw an error. ``` domainLister, ok := registrar.(providers.DomainLister) if !ok...

@tlimoncelli It doesn't crash for me (otherwise I wouldn't have submitted the PR :D). Can you confirm the line of code it is crashing on? (Line 276 in my branch...

@tlimoncelli > I don't understand why that's happening. I read the code and though it should skip the provider properly. :-( I have fixed that with my latest commit. The...

@tlimoncelli did that also fix the second crash you experienced, or is that still present?

@tlimoncelli > Sadly CSCGLOBAL is still listing every zone :( Unfortunately I cannot solve that without more information. I listed some things to look at in [this comment](https://github.com/StackExchange/dnscontrol/pull/2050#discussion_r1096624605). Additionally, could...

Hi @tlimoncelli I'm glad you found the issue! I have also reviewed #2061: Personally, I feel like the `setFromStrings` is too much boilerplate (that needs brainpower to be understood as...

@tlimoncelli I have changed some things to make the code easier to understand (i.e. replaced the loop over `DnsProviderNames` with a simple check if the relevant key exists, split up...

@tlimoncelli > It doesn't work for CSCGLOBAL. I'm a bit confused. I thought the CSCGLOBAL issue was caused by not wrapping the provider in `DnsProvider(..)` in your `dnsconfig.js`?

> > @tlimoncelli > > > It doesn't work for CSCGLOBAL. > > > > > > I'm a bit confused. I thought the CSCGLOBAL issue was caused by not...