disentangling-vae icon indicating copy to clipboard operation
disentangling-vae copied to clipboard

Minor bug in loss logging

Open kuangdai opened this issue 4 years ago • 1 comments

Line 109 in disvae/models/losses.py:

if not is_train or self.n_train_steps % self.record_loss_every == 1:

This does not work when self.record_loss_every is 1 (recording all mini-batches).

Fix:

if not is_train or (self.n_train_steps - 1) % self.record_loss_every == 0:

kuangdai avatar Jun 29 '21 15:06 kuangdai

Ohh I somehow I missed that... Thanks, if you send a PR I'd be happy to merge it!

YannDubs avatar Jul 05 '23 18:07 YannDubs