nouislider-angular icon indicating copy to clipboard operation
nouislider-angular copied to clipboard

Add support for es6 import

Open imaksp opened this issue 9 years ago • 7 comments

Please add support for es6 import. e.g. for ui-router import uiRouter from 'angular-ui-router'

imaksp avatar Jul 19 '16 12:07 imaksp

@aks0020 I am a bit short of time, maybe you want to make pr?

Yankovsky avatar Jul 19 '16 12:07 Yankovsky

+1

ekarudianto avatar Oct 11 '16 02:10 ekarudianto

Hi @Yankovsky I've forked your repo and made my self the directive and the support of using es6 here

https://github.com/ekarudianto/nouislider-angular-es6

I put your name as the original creator, would you mind if I publish it to npm ? since I'd like to use it personaly for my current project ?

ekarudianto avatar Oct 11 '16 15:10 ekarudianto

@ekarudianto @aks0020 just to clarify, what is the point of using es6 imports in this lib? It only depends on noUiSlider and assumes that it is available in window object.

Yankovsky avatar Oct 11 '16 21:10 Yankovsky

Yes I was using webpack as the build tool, and it won't work if I just do 'import' from your repo since you're not treat it as a module .. @Yankovsky

ekarudianto avatar Oct 12 '16 08:10 ekarudianto

@ekarudianto @aks0020 do you still need this feature?

Yankovsky avatar May 17 '19 06:05 Yankovsky

Hi @Yankovsky, not really anymore no :) sorry for the late reply

ekarudianto avatar Aug 12 '19 18:08 ekarudianto