uCrop icon indicating copy to clipboard operation
uCrop copied to clipboard

Improve circle dimen layer in 19+ devices

Open hearsilent opened this issue 5 years ago • 2 comments

Improve circle dimen layer in 19+ devices

Screenshots

Pre 19 devices

device-2018-10-01-165110 2018-10-01 4 56 41

19+ devices

device-2018-10-01-163732 2018-10-01 4 56 31

hearsilent avatar Oct 01 '18 09:10 hearsilent

@shliama Can you review this PR 🙏 Thx!

hearsilent avatar Oct 02 '18 02:10 hearsilent

@hearsilent , I've reviewed your PR and it seems to be promising. However, there is one peculiarity that arose with the introduced code. Currently, the library provides dimmed layer for the outer boundaries of the circle in the edit mode. Once the picture is edited the dimmed layer is removed and the image is saved without dimmed outer layer. Current_edit Current_result

However, your PR introduces a different behavior. Once the picture is edited, the dimmed layer remains with the saved image: PR_edit PR_result

If you feel that this feature is anticipated, could you please provide additional changes so that such behavior can be adjustable? I mean, to provide some flag that will enable/disable outer circle dimmer after editing. Thank you for your contribution.

dmitriy1morozov avatar Jan 26 '22 09:01 dmitriy1morozov