uCrop
uCrop copied to clipboard
Improve circle dimen layer in 19+ devices
Improve circle dimen layer in 19+ devices
Screenshots
Pre 19 devices
19+ devices
@shliama Can you review this PR 🙏 Thx!
@hearsilent , I've reviewed your PR and it seems to be promising. However, there is one peculiarity that arose with the introduced code. Currently, the library provides dimmed layer for the outer boundaries of the circle in the edit mode. Once the picture is edited the dimmed layer is removed and the image is saved without dimmed outer layer.
However, your PR introduces a different behavior. Once the picture is edited, the dimmed layer remains with the saved image:
If you feel that this feature is anticipated, could you please provide additional changes so that such behavior can be adjustable? I mean, to provide some flag that will enable/disable outer circle dimmer after editing. Thank you for your contribution.