Koloda public func swipe(_ direction: SwipeResultDirection, force: Bool = false) not working when button tapped quickly multiple times.

public func swipe(_ direction: SwipeResultDirection, force: Bool = false) not working when button tapped quickly multiple times.

Open keshavx11 opened this issue 7 years ago • 15 comments

if !animationSemaphore.isAnimating

this condition is failing

Oct 18 '18 10:10 keshavx11

Not positive but isn't the idea that you have to wait for a swipe to finish animating before the method fires again?

Jan 21 '19 19:01 shaandsingh

@shaandsingh you are correct but from user's perspective, it still takes time even after the card has gone out of sight. For them the animation has completed and they can see only the new card. Looks like isAnimating takes more time to reset than it should.

Changing the drag speed from default to .fast made the experience better though.

Jan 22 '19 07:01 keshavx11

Got it. Does swipe force = true help? On Jan 22, 2019, 2:04 AM -0500, Keshav Bansal [email protected], wrote:

@shaandsingh you are correct but from user's perspective, it still takes time even after the card has gone out of sight. For them the animation has completed and they can see only the new card. Looks like isAnimating takes more time to reset than it should. Changing the drag speed from default to .fast made the experience better though. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Jan 22 '19 14:01 shaandsingh

Just tried. Doesn't help.

Jan 23 '19 05:01 keshavx11

+1 to this