Yakov Litvin

Results 122 comments of Yakov Litvin

Here's the problem: in Firefox * content-script.js injects patch-classic-io.js into the page * patch-classic-io.js modifies `window.mozillaLoadFile` and others; in Chrome patch-classic-io.js is injected, but [it gets a sandboxed context](https://stackoverflow.com/a/12396221/3995261) and...

Not sure, could you provide a sample code? The following seems to work: 1. change `injectExtensionScript` to this: function injectExtensionScript(text) { const scriptElement = document.createElement("script"); scriptElement.innerHTML = text; document.head.appendChild(scriptElement); scriptElement.remove();...

Yes, that would be helpful (so that I can create PRs with more confidence)

Actually, that worked in Firefox: I loaded Timimi extension from cloned and edited repo on local file system and it interacted with Timimi backend just like the main extension. Not...

well, this doesn't seem to be working. To be sure, I've retested in Chrome (instead of Vivaldi), but it's the same: 1. I have installed the unpacked extension 2. copied...

Hi Riz, any comments on this? What do you think about merging #48 so that we can use this minimal implementation in the next release and improve it further if...

Great, thanks! Yeah, the security check is indeed is an interesting question because such code injection may be considered "hacky". By the way, do you have any plans to de-duplicate...

Hi Riz, > we have to see is if it passes the chrome store's security check any news on this? What's the usual time they take to review an updated...

I have to note that Timimi backuping [was not implemented](https://github.com/ibnishak/Timimi/pull/24/files#diff-d74e3e4776d5398eb6dd97e6803dec43R18) for TWC yet (the `message` should also get `data-tiddlyfox-backup-path` attribute [for supporting backuping](https://github.com/ibnishak/Timimi/blob/master/addon-firefox/content-script.js#L106)), so I'm not sure what's the status...

> Although Timimi doesn't handle the backing-up message (which I suspect, because I can see "TWC backup" files saved there in fact), it will back up anything that indicated by...