guerilla icon indicating copy to clipboard operation
guerilla copied to clipboard

Published 20 hours ago • verified publisher icon YahooArchive

Babel and ES6 Utilities Class

Open nickwph opened this issue 8 years ago • 5 comments

nickwph avatar Mar 18 '16 15:03 nickwph

looks like the tests is actually failing, could you take a look? @seyeojumu https://travis-ci.org/yahoo/guerilla/jobs/116933560

nickwph avatar Mar 18 '16 16:03 nickwph

CLA is valid!

yahoocla avatar Mar 18 '16 16:03 yahoocla

Unit test fixed. Please take a look and merge it maybe. :smile:

nickwph avatar Mar 21 '16 21:03 nickwph

Made a couple changes based on information from here. Something to be aware of -- the tests seem to take much longer to run now; especially on v0.12.

Maybe we should probably re-organize the package.json a little bit -- create a build target so that the transpiling happens only once?

Anywho, LGTM +1

seyeojumu avatar Mar 22 '16 03:03 seyeojumu

the tests does seem taking longer than before on travis, on my computer it seems fine.

do you mean we could check in the compiled javascript (from babel)? in webstorm *-compiled.js.map and *-compiled.js would be generated if i set up a watcher. but i felt like it is too webstorm-specific and i just ignored them.

nickwph avatar Mar 22 '16 03:03 nickwph