fake-server icon indicating copy to clipboard operation
fake-server copied to clipboard

Cesinrm

Open cesinrm opened this issue 8 years ago • 10 comments

Hi!

I've just added some new features.

delOne. Instead of flush, now, you can delete a route one by one.

getAll. Retrieve all routes.

add. Modified to accept 'verb' as part of the route.

I've also added a poor posibility to retrieve the HOWTO as html. Guess you like it and sorry with commit's mess! It's my first github contribution and my first node.js, too!

Regards.

cesinrm avatar Apr 07 '16 08:04 cesinrm

Thanks for your contribution. A few questions/requests tho:

  • What is the rationale behind creating a README2.html and a /howTo endpoint?
  • We use spaces and not "tabs".

all other comments are inline.

bigodines avatar Apr 08 '16 17:04 bigodines

You're welcome!

@bigodines well, when I found your work throught github, I guessed that I could put it in my lan for my coworkers. So, README2.html and a /howTo endpoint, it's just a simple way to explain how it works for'em.

Sorry for tabs!!! I forgot to change my editor configuration for js... :O

cesinrm avatar Apr 09 '16 17:04 cesinrm

I did some new changes with last commit. Hope everyhting is right.

Regards.

cesinrm avatar Apr 12 '16 15:04 cesinrm

I also have a change to add CORS if you want.

cesinrm avatar Apr 12 '16 15:04 cesinrm

Hi, @bigodines, I'm not sure if you think that I have to improve something. Don't hesitate to tell me.

Regards.

cesinrm avatar May 02 '16 20:05 cesinrm

unfortunately, I've lost permissions to merge your PR to this project as I don't work for yahoo anymore and have been removed from the github organization :(

bigodines avatar May 09 '16 18:05 bigodines

:s well, I'll wait for the next master developer.

cesinrm avatar May 09 '16 19:05 cesinrm

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

yahoocla avatar May 16 '16 11:05 yahoocla

CLA is valid!

yahoocla avatar May 17 '16 12:05 yahoocla

Anyone owns this repo?

cesinrm avatar Oct 18 '16 09:10 cesinrm