Yahnis Elsts

Results 280 comments of Yahnis Elsts

Too bad that PHP doesn't support keyword (named) arguments. Personally, I would probably go with a new static method. I don't want to break backwards compatibility just to add a...

Personally, I'm leaning towards `$fileName` + an optional `$args` array. Settings in the `$args` array, if present, should have precedence over plugin header fields.

Here are two things to check: - It could be that you're just missing some files. Please make sure that this file exists in the update checker directory and it...

The `vendor` directory in this repository is part of the source and not generated by Composer. If you install this library with Composer, it should automatically download everything including that...

I'm not sure what you mean by "bundle your features via composer". Judging by [the Packagist stats for this library](https://packagist.org/packages/yahnis-elsts/plugin-update-checker/stats), lots of people already use this package via Composer. Presumably,...

@ddur: That sounds unrelated to the topic of this issue; please make a new issue instead.

@ddur: Thanks, I'll take a look later,

Do you have any ideas about which part of the update checker could be causing the performance issues? Is the actual update check, or something else? I would recommend doing...

That's a huge difference. If you're interested in investigating this further, I'd be curious to see if the slowdown is just due to a few slow network requests or some...

Those requests look fine to me. They're a little slower than I would expect, but other than that PUC seems to be working as designed. It checks a few different...