YOURLS icon indicating copy to clipboard operation
YOURLS copied to clipboard

Replace deprecated get_all_options filter with an action

Open RavanH opened this issue 2 years ago • 1 comments

Code of Conduct

Submission validity

  • [X] This is not a personal support request, that should be posted on discussions community.
  • [X] I checked current issues and this request isn't a duplicate of an existing issue, opened or closed.

Summary

Hi, this get_all_options filter has apparently been deprecated and does not allow getting all options anymore. And as far as I can figure, there is no alternative wrapper function available...

Motivation

For effective persistant options caching, plugins like APC Cache and YAPCache depended on the get_all_options filter. This filter has apparently been deprecated and does not allow getting all options anymore. This is needed to populate the cache.

Describe the solution

On includes/Database/Options.php line 78 there is currently yourls_apply_filter('get_all_options', 'deprecated');

What if that was replaced with yourls_do_action('get_all_options', $options); then a cache plugin could hook there and fetch all options at that time to populate the persistant cache.

RavanH avatar Dec 12 '23 15:12 RavanH

Unless the idea is top move all actions (and deprecated filter) in the Options class to their corresponding wrapper functions? In that case, I'll be happy to work on that :)

RavanH avatar Dec 13 '23 13:12 RavanH