GoogleMaps-SP icon indicating copy to clipboard operation
GoogleMaps-SP copied to clipboard

Support for Apple Silicon

Open dplisek opened this issue 2 years ago • 6 comments

In order for this project to generate xcframeworks that work with the same level of perfection on all devices including Apple Silicon simulators, we needed prebuilt Google binaries that are intended for those simulators. This is why I switched to using binaries that are hidden inside Google's beta-version xcframeworks.

Carthage now downloads the beta xcframeworks from Google, instead of the older frameworks. This is so that all the universal binaries hidden inside are made available.

References inside GoogleMaps.xcodeproj have been redirected to their respective counterparts in the xcframeworks – those intended for real devices.

A new project, GoogleMaps-Sim.xcodeproj, has been created, which works the same way, but is pointed at the files inside the xcframeworks that are intended for universal simulator devices (Intel and ARM).

The make_xcframework.sh script has been updated so that the new GoogleMaps-Sim.xcodeproj project is used when generating the framework which is intended for simulators.

dplisek avatar Feb 24 '22 17:02 dplisek

~~Can we please get it merged? it works perfectly with M1 didn't check on intel with this branch though.~~

Edit: sorry, I'm taking it back. Although it compiles successfully without Rosetta, the app crashes when trying to render Google Maps.

oronbz avatar Sep 05 '22 14:09 oronbz

@oronbz I've set Metal renderer to fix this issue:

GMSServices.setMetalRendererEnabled(true)

rbsgn avatar Oct 07 '22 13:10 rbsgn

Thanks @rbsgn I really hope this will get merge and this repository will keep being maintained, if it won't happen I don't mind collaborating with you on your fork or mine to keep this alive.

oronbz avatar Oct 07 '22 19:10 oronbz

Hey @rbsgn, any chance that this could be rebased on top of the new 7.1.0 version here?

oronbz avatar Oct 27 '22 06:10 oronbz

Hi @oronbz! What do you mean by “this”? This repository? I don’t own it and can’t rebase it, sorry. There is another fork that already uses 7.1.0.

rbsgn avatar Oct 27 '22 07:10 rbsgn

@rbsgn I mean rebase your branch on top of the main branch here, I know you don't own it (👍

Just trying the other fork now, thank you!

oronbz avatar Oct 27 '22 07:10 oronbz