yacs
yacs copied to clipboard
YACS-RCOS
Various alignment and proportion fixes
A lot of things were misaligned, so I shifted everything. These should look correct for most reasonable zoom values.
Comparison:
Before:
After:
Thanks for the PR @Shadowsoftime99 !! These changes look really nice. My only concern is whether the alignment changes affect mobile screens. I'll test it out when I have a chance, but it would be helpful if you could post a screenshot of how the changes look on an iphone 6 size screen (375px width)
Ah, sorry this took so long as I was away from my computer the entire week. The alignment on iPhone 6/7/8 portrait screen goes from bad... to a different kind of bad. The screen just isn't wide enough for either version to display properly. Landscape, the screen is wide enough to match the results seen above on desktop screens.
Before:
After:
@Shadowsoftime99 Unfortunately I can't merge this if it makes the mobile view significantly worse. We need to support that screen size in portrait.
It would be really great to see them both optimized. It may be necessary to make liberal use of media selectors, which is fine.
It works (tm)! The CSS is now set up to revert to a different format whenever the screen width is less than 600px (the point at where the desktop layout breaks down). This is what it looks like on an iPhone 6 (375px width). I also made an adjustment to the course description text, because justifying text when it can only fit 1-3 words per line does not look right.
You should probably make the max-width 575.98 like it is everywhere else on the site
Ah, I see. I introduced a separate set of CSS parameters below 575.98px, but used 375px to balance them because that is the width of most phones in portrait orientation. That's why the issues are occuring.
I've decided that I will leave this PR as is as I need to uninstall YACS-relevant tools for storage space on my laptop, and if others would like to complete it they are free to. Feel free to message me on Mattermost (@tyler-machado) if you have any questions about what I have done!