yacreader icon indicating copy to clipboard operation
yacreader copied to clipboard

ordering issue

Open talmroth opened this issue 4 months ago • 0 comments

https://github.com/YACReader/yacreader/blob/5f03fc5f1fd354042f57584a7109e7dc2b0e8f0b/YACReaderLibrary/db_helper.cpp#L1425

I think the logic for ordering is flawed. In looking at the code a count is done on the table and the new row is added with an ordering of row count + 1. The problem is if you delete anything from the middle of the list and then add something to the list it gets inserted with an ordering that is not at the end since the rowcount is now lower than the highest ordering value.

I think this is true of all the insert routines.

talmroth avatar Oct 14 '24 05:10 talmroth