Y.

Results 31 comments of Y.

> In order to test this end-to-end, I've continued work at [hydradatabase/pg_duckdb-docker](https://github.com/hydradatabase/pg_duckdb-docker), complete with pushes to [ghcr.io/hydradabase/pg_duckdb](https://github.com/hydradatabase/pg_duckdb-docker/pkgs/container/pg_duckdb), which required a few secrets and such (notably, an extra login to Dockerhub...

++ agreed. I think to be able to ship this PR we need to: * implement build cache * parallelize build * have the build take O(minute) (not 3h like...

> At quick glance, there are calls to get_namespace_oid() and get_relname_relid() in DuckDBManager::CheckSecretsSeq() that also seem unsafe. > > Is there a general plan for how to sanity check that...

> Closing this in favor of all the smaller PRs that we've been doing to address this problem step-by-step Yeah I was going to re-use this as the final PR...

I looked a bit into this: the problem doesn't come from `pgduckdb_get_querydef` ignoring conversion, but from PG resolving `generate_series` using `int4` types, thereby rendering the `int` cast obsolete: ```SQL SELECT...

> Thanks for the PR! These are virtual methods that are inherited from [here](https://github.com/duckdb/duckdb-httpfs/blob/main/extension/httpfs/httpfs.cpp?rgh-link-date=2025-05-26T16%3A13%3A29Z#L40) so there are required there. Ah that makes sense! Sorry, I should have grepped other repos!...

> Thanks, I see code as is (without the override in `duckdb-httpfs` or potentially other extensions sort of hangs), but I think that all together this works correctly as-is. >...

> I see there is something weird in the code, but I would prefer not to add the default parameters. > > If you want to add an overload, that...

I looked a bit into this and got confused since `SELECT generate_series(1,1000)` doesn't return the same thing: * in DuckDB, it returns one row which contains an array of 1000...