sw-exporter icon indicating copy to clipboard operation
sw-exporter copied to clipboard

Published 20 hours ago • verified publisher icon Xzandro

Added new rune efficiency setting

Open Foolishmetal opened this issue 1 year ago • 2 comments

Added a new setting that calculates rune efficiency based on SWOP's updated formula.

Foolishmetal avatar Aug 13 '23 01:08 Foolishmetal

We already talked about this in Discord, but just so I do not forget.

Personally, I would do the manipulation of the substats directly in the rune-efficiency plugin code (if the new SWOP efficiency setting is enabled of course) and then send that to the function to keep the function clean and without side effects. Remove getRuneEfficiencySWOP, add a new setting to the existing rune-efficiency plugin, if that setting is enabled manipulate the rune props before sending it to the function. This way, you have minimal code adjustments, can use an easily accessible settings and no duplicate code.

Xzandro avatar Aug 16 '23 02:08 Xzandro

Is this still being worked on?

Xzandro avatar Nov 10 '23 15:11 Xzandro