Xynnn_ comments

Results 284 comments of


                                            Xynnn_

Verifier: Add IBM Secure Execution driver framework

https://github.com/confidential-containers/guest-components/pull/492 was merged. we should update the rev in https://github.com/confidential-containers/trustee/blob/main/kbs/tools/client/Cargo.toml#L21

Staged images and release images have different names

Well. I think we can just rename the left images aligning with the right. As the left are all staged images, we do not need to rename and re-push them.

Expose init_data to policy

That's good points and I agree to provide them into OPA. Overall I think KBS is the right place to check plaintext of initdata and potential [runtime data](https://github.com/confidential-containers/trustee/issues/259) rather than...

AS | Use hex encoding rather than base64 in parsed claims

Now SGX/TDX/SNP/SE/vTPM all are using hex.

AS | Use hex encoding rather than base64 in parsed claims

Looks like SNP is using base64 for parsed claims while hex for initdata

AS | Use hex encoding rather than base64 in parsed claims

> I agree, we should unify on a single encoding practice. If I remember correctly, I believe base64 was selected because of how the qemu interfaces were defined, though I...

KBS: Be more tolerant to policy rego files

cc @jialez0 this might be related to encoding things

[AS] Return generic report_data & init_data field in Attestation Claim

Tasklist - [ ] Sample - [ ] SGX - [x] TDX - [ ] SNP - [ ] Azure-vTPM-SNP - [ ] CSV - [ ] CCA

[AS] Return generic report_data & init_data field in Attestation Claim

> Second, is there any way in the source to make sure that developers don't forget to add the right claims to the map? I'm not really aware of a...

[AS] Return generic report_data & init_data field in Attestation Claim

> @Xynnn007 is the idea to remove the report_data and init_data arguments from the evaluate method once all the verifiers return those values in the claims map? Yes. Leaving the...