D3Feat.pytorch icon indicating copy to clipboard operation
D3Feat.pytorch copied to clipboard

About calculating dist_keypts

Open houyongkuo opened this issue 2 years ago • 2 comments

Hello, I see that you are using dist_keypts = cdist(sel_P_src, sel_P_src) instead of dist_keypts = cdist(sel_P_src, sel_P_tgt) when calculating dist_keypts, why is this? Thanks

houyongkuo avatar May 11 '22 02:05 houyongkuo

yes, I found that problem too! I think it should be dist_keypts = cdist(sel_P_src, sel_P_tgt) . @HOUYONGKUO @XuyangBai

2019EPWL avatar Nov 03 '22 09:11 2019EPWL

yes, I found that problem too! I think it should be dist_keypts = cdist(sel_P_src, sel_P_tgt) . @HOUYONGKUO @XuyangBai

But after my test, code dist_keypts = cdist(sel_P_src, sel_P_src) can indeed get a better result, I don't know the reason.

houyongkuo avatar Nov 24 '22 11:11 houyongkuo