Menotexport icon indicating copy to clipboard operation
Menotexport copied to clipboard

Add a timeout when extracting pdf highlights

Open vinnyricciardi opened this issue 7 years ago • 1 comments

This is a great and useful project - thanks for making it! I noticed that for certain pdfs Menotexport hangs at extracthl2.extractHighlights2. I fixed a local copy of this script to include a timeout using the Timeout package. It fixed my issue. Would you like me to contribute this addition to your project?

vinnyricciardi avatar Nov 14 '17 16:11 vinnyricciardi

Thanks for the feedback!

I've seen it slows down sometimes but never seen it hangs, but it would be a good choice to time it out and add the failed pdf to the fail list in such cases. I also think it would be better to set the default time out period to be relatively long as people tend to use this as a one-time tool, so I feel slower execution time is more tolerable than not getting the results. And finally, is it possible to implement this without introducing extra external package?

Xunius avatar Nov 15 '17 00:11 Xunius