Xuanwo comments

Results 1650 comments of


                                            Xuanwo

test: ofs

Hi, I'm currently working on a significant refactor that I expect to complete this week. Would you like to wait the review until then? Thank you.

Operator::lister_with should have an option to return itself if it's already a file path

I don't think we should add a new option for this. Maybe we should let services return the path itself if it exists. For example: ```shell a/ a/b a/bb a/c...

Operator::lister_with should have an option to return itself if it's already a file path

We are returning the dir path itself now.

feat: support pushdown predicate into iceberg engine

Thank you for working on this!

feat: support pushdown predicate into iceberg engine

> need upgrade iceberg and opendal @Xuanwo Yep, I will work on this.

[EPIC] Iceberg-rust Write support

Hi @liurenjie1024, does this epic issue reflect the most recent status? Could you update it and add any PRs that are awaiting review? I’m happy to help this move forward.

bug: behavior tests try to create huge files with large `write_total_max_size`

It seems that even S3 didn't set this value. I feel like it doesn't make sense to provide such a capability directly in services. It also overlaps somewhat with `write_multi_max_size`....

bug: behavior tests try to create huge files with large `write_total_max_size`

This issue can connect to https://github.com/apache/opendal/issues/5846. Maybe what we need is simply to control our test cases instead of relying on a public API capabilities API. It should be good...

new feature: Generate permanent URL for public read

Maybe we can just return the url directly if `allow_anonymous` has been enabled?

RecordBatchTransformer: Handle schema migration and column re-ordering in table scans

Waiting for @liurenjie1024 to take another look.