Xuanwo

Results 1638 comments of Xuanwo

Sorry for the long wait. I believe this PR is ready to go. Would you like to help resolve the conflicts?

Thank you @westonpace for the quick review. > You could use Datafusion's implementation as motivation. They have a `gen` binary application which uses Prost to generate the code and then...

I have reviewed most PRs that I am confident can be merged. The only one left is https://github.com/apache/iceberg-rust/pull/615, for which I need more input.

Hi, @c-thiel, thanks a lot for working on this. This issue does seem complex. I didn't join the discussion before, so I will take some time to go through all...

I believe using `enum` here is sufficient. It's acceptable for us to have some duplicated code since we know the APIs we need are limited and unlikely to expand significantly...

Hi, thank you for bringing this up. I feel it's a bit too complex for us. Could we maintain a static structure like `TableProperties` and `TableS3Properties`? We could implement a...

I'm willing to help with the release about pyiceberg_core.

Hi, [`S3::customized_credential_load`](https://docs.rs/opendal/latest/opendal/services/struct.S3.html#method.customized_credential_load) should allow you to implement your own logic.

Thank you for the clarification. I now understand what the problem is. My current ideas: - Add an `Sign` trait for entire reqsign ```rust use http; #[async_trait] trait Sign: 'static...

> The new `Sign` trait was introduced in [Xuanwo/reqsign#459](https://github.com/Xuanwo/reqsign/pull/459) and then replaced in [Xuanwo/reqsign#482](https://github.com/Xuanwo/reqsign/pull/482) with the `Load` and `Build` traits which should achieve the same. Hi, that will be included...