Xuanwo

Results 1658 comments of Xuanwo

I will suggest adding a test to hive metastore, maybe the mostly used thrift rpc based services? On my local test, calling hive metastore will meeting EOF errors: ```shell +ERROR...

> This can be opted-out by calling `make_codec` when building the client. Great, let me try again. (As a general thrift rpc framework, I suggest to disable those private protocol...

> Does hive support framed transport? Framed transport is much more faster than simple buffered binary. I'm not sure about that. AFAIK, Most hive users are using binary protocol.

Seems changing into `framed` can't resolve this issue. Hive does support framed transport, but it's not enabled by default. ```shell +ERROR 1105 (HY000) at line 2: Internal. Code: 1001, Text...

> @Xuanwo Any other questions? There are two things in my mind now: The frist, do we really need an extra `GcsVersionsLister`? It seems nearly the same with `GcsLister`. Then,...

> 1. `GcsVersionsLister` and `GcsLister` have different processing strategies. Hi, s3 split them because we need two different API calls, requiring distinct parsing logic. However, GCS doesn’t have this issue;...

> If we get versioned output, we also need to group and sort the entities, and the processing flow is different from non-versioned. Hey, I don't understand. We should definitely...

Hi, seems our tests failed for: ``` Unsupported (persistent) at Deleter::delete => The service gcs does not support the operation Deleter::delete with the arguments version. Please verify if the relevant...

Hi @hoslo, sorry for the late. Would you like to resolve the conflicts? I will try to find sometime to setup the CI.

I perfer to integrate tools that existing in c or cpp ecosystem, like glog. Using `tracing` or `env-logger` in c/cpp projects seems not a good idea.