lilygo-micropython icon indicating copy to clipboard operation
lilygo-micropython copied to clipboard

Fixed a relative path refernce in a cmake file.

Open jdownie opened this issue 1 year ago • 7 comments

I was unable to compile in my machine without this change. Hopefully this is a sensible change to offer upstream.

jdownie avatar Jul 12 '23 22:07 jdownie

I faced the same problem and this commit solved it. Big thanks to @jdownie

MrDolch avatar Jul 29 '23 11:07 MrDolch

Yes, this fixed the issue. Please merge into main branch.

He-Peter-Huang avatar Dec 02 '23 03:12 He-Peter-Huang

Is there something else i could or should do to help this into the upstream project @He-Peter-Huang ?

jdownie avatar Dec 04 '23 09:12 jdownie

@jdownie The problem you encountered may be caused by the incorrect commit id of lcd_binding_micropython. You can try to use https://github.com/lbuque/micropython-builder

lbuque avatar Dec 04 '23 09:12 lbuque

Is there something else i could or should do to help this into the upstream project @He-Peter-Huang ?

I tried pulling micropython to the latest build, no luck, encountered a couple of errors. Could someone try to bump it to the latest version? The new mip seems a lot friendlier than the old upip.

He-Peter-Huang avatar Dec 04 '23 13:12 He-Peter-Huang

Thanks for the suggestion @lbuque . I think that this means that my solution might have yielded a positive result and helped @He-Peter-Huang , but it's not addressing the root cause. I think @He-Peter-Huang and I are keen to see my PR rejected and the other branch that you volunteered merged so that people like us get the best available version by default instead of getting lost among these branches. Have you submitted a PR for your solution?

jdownie avatar Dec 04 '23 20:12 jdownie

@jdownie Please check out #35

lbuque avatar Dec 05 '23 01:12 lbuque