D3Dnet icon indicating copy to clipboard operation
D3Dnet copied to clipboard

self.length in DeformConvPack_d

Open mfaizan-ai opened this issue 1 year ago • 5 comments

Thank you for the excellent work! I noticed that self.length is checked for values 1 and 2, but in the case of THW, shouldn’t it be 3? Could you clarify this?

Additionally, could you explain the meanings of DeformConv, DeformConv_d, DeformConvPack, and DeformConvPack_d? When should each of these be used?

mfaizan-ai avatar Oct 05 '24 09:10 mfaizan-ai

see issue #12.

XinyiYing avatar Oct 06 '24 11:10 XinyiYing

@XinyiYing self.length is defined for dimension 2 and 1, however, the dimensions for 'hwd' is 3. I don't understand that.

mfaizan-ai avatar Oct 09 '24 04:10 mfaizan-ai

"DeformConvPack" is used for D3D deforming in three dimensions (using its own offsets) "DeformConv" is used for D3D deform in three dimensions (using extra offsets)

"DeformConvPack_d" is used for D3D deforming in option 2 or 1 dimensions (using its own offsets) "DeformConv_d" is used for D3D deforming in option 2 or 1 dimensions (using extra offsets)

Please refer to ./dcn/test.py for example usage.

XinyiYing avatar Oct 09 '24 07:10 XinyiYing

@XinyiYing thank you so much for the detailed explanation

mfaizan-ai avatar Oct 11 '24 11:10 mfaizan-ai

You are welcome.

XinyiYing avatar Oct 14 '24 02:10 XinyiYing