Xinru Zhang

Results 48 comments of Xinru Zhang

/assign I'll take this on since I had written some test codes (but still working on making the test case pass :p) if @afrittoli hasn't started :)

I'm closing this PR because we've made changes to `v1beta1.CustomRun`. We can leave it as what it is for `v1alpha1.Run`. Please feel free to comment if there's any other concerns.

It would be great if we can create an issue to track the removal of this ConfigMap (Didn't find it in the v0.46 Milestones so if you've created, please add...

Hi @Yeroha, thanks for reporting the issue! It would be helpful if you can attach your pipeline yaml here

@lbernick Unfortunately no, I tried to trace back to https://github.com/kubernetes/kubernetes/blob/ea0764452222146c47ec826977f49d7001b0ea8c/staging/src/k8s.io/code-generator/cmd/client-gen/generators/scheme/generator_for_scheme.go#L157, but nothing wrong with it (it uses spaces instead of tabs) Since we have a workaround -- manually replace `tabs`...

Ah ok, somehow I missed this thread 🤦‍♀️ and was OOO yesterday. Thanks for the comment @afrittoli and @pritidesai. PR is ready! https://github.com/tektoncd/pipeline/pull/6040

@jerop would you mind crossing the last item as https://github.com/tektoncd/pipeline/pull/6040 is merged, thanks~