Xinru Zhang
Xinru Zhang
Thanks @pritidesai @jerop @lbernick for your detailed review, appreciate it a lot! ❤️ I Pushed a new commit to reflect what we've discussed in the comment thread, PTAL :)
/hold Talking with @pritidesai offline about some important details of Option 1, related links: - https://github.com/tektoncd/pipeline/blob/main/docs/variables.md - https://github.com/tektoncd/pipeline/pull/3770 Will update the TEP soon.
Hi @ScrapCodes, thanks for the comment! Yes, that's a great question. I don't think we have a way to enforce that, this is more of a contract we build with...
We(me and Prashant) have reached agreement in an offline discussion on last Friday, see the [meeting note](https://docs.google.com/document/d/1YjC-AUpyFf_4zyt2zLnol2J2mEN7o0DqBgrti02tSZc/edit?usp=sharing). Thanks for the great discussion! @ScrapCodes
Thanks for the well-structrued todos @jerop! As we discussed offline, I'm extending the TODOs listed in https://github.com/tektoncd/pipeline/issues/5158#issue-1308334220. I don't have the edit permission on the comment so I'm just copying...
/assign XinruZhang
Currently, we have two ways to run custom tasks: w/ CRD, w/o CRD - With CRD: [task-loop](https://github.com/tektoncd/experimental/tree/main/task-loops) - Without CRD: [wait-task](https://github.com/tektoncd/experimental/tree/main/wait-task) The highest priority of this issue is to create...
- [x] ~move [wait-task](https://github.com/tektoncd/experimental/tree/main/wait-task) to test/~ - [x] ~write e2e test (install tekton, custom controller)~ - [x] ~put this e2e test together with other tests? (not sure if this is...
After talking to @dibyom offline, we reached agreement on implementing a new controller for the testing purpose instead of using the exisitng `wait-task` because 1. `wait-task` will be eventually replaced...